MAINT: result_type cosmetic refactor
#142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
force-pushed
the
result_type_nits
branch
2 times, most recently
from
56a2aa7 to
788e6be
Compare
crusaderky
force-pushed
the
result_type_nits
branch
from
788e6be to
72eabc4
Compare
ev-br
reviewed
Apr 2, 2025
|
|
||
| if len(B) == 0: | ||
| if not dtypes: |
There was a problem hiding this comment.
This got me off at a first glance, but yeah it's OK because dtypes contains both arrays and dtypes.
Is fine, even if resembles a bit a snippet I recently saw in somebody's going through the "intro to python" online course: mytuple = [].
There was a problem hiding this comment.
The dtypes list contains exclusively dtypes though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.